From 8820cd897e86516fad852bd5d28096463064b27e Mon Sep 17 00:00:00 2001 From: Joan Date: Sat, 7 Feb 2026 23:30:33 +0100 Subject: [PATCH] fix(ui): disable scrolling when dropdown is open --- pwa/src/components/common/GameDropdown.tsx | 11 +++++------ pwa/src/components/game/LocationView.css | 15 +++++++++------ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/pwa/src/components/common/GameDropdown.tsx b/pwa/src/components/common/GameDropdown.tsx index 529f8bf..ad7ba5e 100644 --- a/pwa/src/components/common/GameDropdown.tsx +++ b/pwa/src/components/common/GameDropdown.tsx @@ -55,15 +55,14 @@ export const GameDropdown: React.FC = ({ // Use mousedown to catch clicks before they might trigger other things document.addEventListener('mousedown', handleClickOutside); - // Handle scroll to update position or close? - const handleScroll = () => { - // Optional: onClose(); - }; - window.addEventListener('scroll', handleScroll, true); + // Disable scrolling while dropdown is open + const originalOverflow = document.body.style.overflow; + document.body.style.overflow = 'hidden'; return () => { document.removeEventListener('mousedown', handleClickOutside); - window.removeEventListener('scroll', handleScroll, true); + // Restore scrolling + document.body.style.overflow = originalOverflow; }; }, [isOpen, onClose]); diff --git a/pwa/src/components/game/LocationView.css b/pwa/src/components/game/LocationView.css index 17e42be..b72ab40 100644 --- a/pwa/src/components/game/LocationView.css +++ b/pwa/src/components/game/LocationView.css @@ -9,25 +9,28 @@ } /* Padded Image for enemies */ -/* Padded Image for enemies - Matches item card structure but with padding */ -.padded-image { +.grid-card .entity-image.padded-image { padding: 10px; - box-sizing: border-box; width: 100%; height: 100%; display: flex; align-items: center; justify-content: center; overflow: hidden; + margin: 0; } -.padded-image img { +.grid-card .entity-image.padded-image img { width: 100%; height: 100%; - object-fit: contain !important; - /* Ensure enemies don't get cropped */ + object-fit: cover !important; + /* Crop to 1:1 as requested */ + display: block; + margin: 0; } + + /* Remove old expanded grid styles */ .corpse-container { display: contents;